wip REF: redirect df.to_html to Styler if new kwargs are used.
#45090
Conversation
| @@ -2865,16 +2865,29 @@ def to_html( | |||
| justify: str | None = None, | |||
| max_rows: int | None = None, | |||
| max_cols: int | None = None, | |||
| show_dimensions: bool | str = False, | |||
| show_dimensions: bool | str | None = None, | |||
There was a problem hiding this comment.
dont' you want these as lib.no_default? (e.g. to see if the user passed them)?
There was a problem hiding this comment.
probably, I've not really used lib.no_default before and a previous suggestion was to use None. Happy to investigate and switch if preferred.
There was a problem hiding this comment.
None is fine to use for this purpose, as long as it is not a valid value for the keyword
| encoding: str | None = None, | ||
| *, | ||
| table_attributes: str | None = None, |
There was a problem hiding this comment.
why are you adding the new options?
There was a problem hiding this comment.
this suggestion by @jorisvandenbossche #44451 (comment)
# Conflicts: # doc/source/whatsnew/v1.4.0.rst
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
@attack68 do you still want to work on this? |
|
@datapythonista I do but it requires some pre requisites and a community consensus. There is a bit more progress on |
This is an alternatative way of transitioning
DataFrame.to_htmltoStyler.to_html.It is a very minimalist introduction:
here is the rendered doc-strings:
